Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Currency on recovered profile #18433

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

smohamedjavid
Copy link
Member

fixes #18199

Summary

This PR fixes the currency symbol not shown on the recovered profile.

Review Notes

The bug is caused by to assoc setting value without data sanitization.

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Recover any profile created before 14.12.2023
  • Verify the currency symbol is shown on the Wallet

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jan 8, 2024

Jenkins Builds

Click to see older builds (14)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0cd2c12 #1 2024-01-08 17:22:02 ~5 min tests 📄log
✔️ 0cd2c12 #1 2024-01-08 17:22:10 ~5 min ios 📱ipa 📲
✔️ 0cd2c12 #1 2024-01-08 17:23:01 ~6 min android-e2e 🤖apk 📲
✔️ 0cd2c12 #1 2024-01-08 17:23:58 ~7 min android 🤖apk 📲
a1d2179 #2 2024-01-09 13:27:58 ~2 min ios 📄log
✔️ a1d2179 #2 2024-01-09 13:31:59 ~6 min android-e2e 🤖apk 📲
53c7d5d #3 2024-01-10 09:42:35 ~7 min ios 📄log
✔️ 53c7d5d #2 2024-01-10 09:42:48 ~7 min tests 📄log
✔️ 53c7d5d #3 2024-01-10 09:44:03 ~8 min android-e2e 🤖apk 📲
✔️ 53c7d5d #3 2024-01-10 09:44:27 ~9 min android 🤖apk 📲
✔️ 695f9cd #3 2024-01-11 19:50:19 ~5 min tests 📄log
✔️ 695f9cd #4 2024-01-11 19:51:26 ~7 min android 🤖apk 📲
✔️ 695f9cd #4 2024-01-11 19:52:13 ~7 min android-e2e 🤖apk 📲
✔️ 695f9cd #4 2024-01-11 19:57:53 ~13 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8c763ce #4 2024-01-18 09:53:34 ~6 min tests 📄log
✔️ 8c763ce #5 2024-01-18 09:54:39 ~7 min android-e2e 🤖apk 📲
✔️ 8c763ce #5 2024-01-18 09:55:27 ~8 min android 🤖apk 📲
✔️ 8c763ce #5 2024-01-18 09:55:46 ~8 min ios 📱ipa 📲
✔️ c6d2483 #6 2024-01-19 14:26:08 ~6 min ios 📱ipa 📲
✔️ c6d2483 #6 2024-01-19 14:27:34 ~7 min android 🤖apk 📲
✔️ c6d2483 #6 2024-01-19 14:27:34 ~7 min android-e2e 🤖apk 📲
✔️ c6d2483 #5 2024-01-19 14:31:54 ~12 min tests 📄log

@smohamedjavid smohamedjavid marked this pull request as ready for review January 8, 2024 17:28
@@ -51,3 +51,10 @@
(visibility-status-updates/<-rpc-settings)
(set/rename-keys {:compressedKey :compressed-key
:emojiHash :emoji-hash})))

(defn rpc->setting-value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason we need to have this in legacy folder? seems like something we can move to profile/datastore.cljs ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and start the migration! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason we need to have this in legacy folder? seems like something we can move to profile/datastore.cljs ?

I placed it in the legacy.* ns as the RPC data helpers for settings are used from it.

(data-store.settings/rpc->settings settings)

Moving the data-store for settings to status-im.* ns would be easy when we do it.

cc @flexsurfer

@smohamedjavid smohamedjavid force-pushed the fix/currency-on-recovered-profile branch from 0cd2c12 to a1d2179 Compare January 9, 2024 13:25
@status-im-auto
Copy link
Member

✔️ status-mobile/prs/android-e2e/PR-18433#2 🔹 ~6 min 50 sec 🔹 a1d2179 🔹 📦 android-e2e package

@smohamedjavid smohamedjavid force-pushed the fix/currency-on-recovered-profile branch 2 times, most recently from 53c7d5d to 695f9cd Compare January 11, 2024 19:44
@smohamedjavid smohamedjavid force-pushed the fix/currency-on-recovered-profile branch from 695f9cd to 8c763ce Compare January 18, 2024 09:47
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 3
Passed tests: 43
IDs of failed tests: 703133,702947 
IDs of expected to fail tests: 703503,702808,703629 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Device 1: Tap on found: CommunitiesTab
    Device 2: Looking for a message by text: something to reply to

    activity_center/test_activity_center.py:302: in test_activity_center_reply_read_unread_delete_filter_swipe
        self.channel_2.chat_element_by_text(message_to_reply).wait_for_visibility_of_element(120)
    ../views/base_element.py:139: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'something to reply to')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button

    critical/chats/test_public_chat_browsing.py:276: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     zQ3...dWXh5 was not restored as a contact from waku backup!
    E    zQ3...Vacac was not restored as a contact from waku backup!
    E    admin_open was not restored from waku-backup!!
    E    member_open was not restored from waku-backup!!
    E    admin_closed was not restored from waku-backup!!
    E    member_closed was not restored from waku-backup!!
    



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community'

    critical/chats/test_public_chat_browsing.py:1178: in test_community_join_when_node_owner_offline
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     open community is not listed inside Pending communities tab
    E    Joined status is not displayed
    E    open community is not listed inside Joined communities tab 
    

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Messages PN was not fetched from offline 
    

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @smohamedjavid thank you for PR. No issues from my side. PR can be merged

    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid smohamedjavid force-pushed the fix/currency-on-recovered-profile branch from 8c763ce to c6d2483 Compare January 19, 2024 14:19
    @smohamedjavid smohamedjavid merged commit 5926426 into develop Jan 19, 2024
    6 checks passed
    @smohamedjavid smohamedjavid deleted the fix/currency-on-recovered-profile branch January 19, 2024 14:33
    Pau1fitz pushed a commit to Pau1fitz/status-mobile that referenced this pull request Jan 22, 2024
    This commit fixes the currency symbol not shown on the recovered profile.
    
    --
    
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Fiat currency marks not displayed for accounts and assets of old recovered users
    6 participants